This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR middle-end/51472: set DECL_GIMPLE_REG_P on TM vector saves


On 12/21/11 08:07, Jakub Jelinek wrote:
On Wed, Dec 21, 2011 at 07:52:16AM -0600, Aldy Hernandez wrote:
Oh neat... create_tmp_reg will do all this for me.

I don't think that update_stmt is needed there. The stmt is freshly allocated a few lines above it: stmt = gimple_build_assign (lp->save_var, unshare_expr (lp->addr)); so the modified flag is still set and thus when you gsi_insert_before it afterwards, it will update_stmt_if_modified, which is the same as update_stmt when the modified flag is set.

Ok, done.



The first hunk looks okay.

Was that an approval? Updated patch attached.

Attachment: curr
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]