This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] MIPS16: Fix truncated DWARF-2 line information
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>, Catherine Moore <clm at codesourcery dot com>
- Date: Wed, 14 Dec 2011 19:11:40 +0000
- Subject: Re: [PATCH] MIPS16: Fix truncated DWARF-2 line information
- References: <alpine.DEB.1.10.1112132001040.5354@tp.orcam.me.uk>
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> After some thinking I decided the simplest approach will be just emitting
> the missing location directive in the context of the MIPS16 thunk being
> built that will apply to the actual function prologue. The resulting
> change is included below -- this just repeats the record originally output
> before the thunk (and which applies to .mips16.fn.sinfrob16 section).
I think I'd prefer to change where the thunc is emitted. We shouldn't
really have the thunk coming between the MIPS16 code and its .cfi_startproc
either. And the thunk should probably have CFI info itself.
I'll try to look at it sometime if you don't beat me to it.
> Regression-testing this change turned out to be quite tricky as current
> trunk does not appear to build for the mips-sde-elf target:
Gah. mipsisa64-elfoabi is another option FWIW.
> and the mips-linux-gnu configuration is not ready yet for MIPS16 testing.
Out of interest, what goes wrong? I've been testing -mabi=32/-mips16 on
mips64-linux-gnu for some time without difficulty.
Anyway, whatever does end up going in to trunk really does need to be
tested against trunk first.
Richard