This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR middle-end/51411: handle transaction_safe virtual inlined methods
- From: Richard Henderson <rth at redhat dot com>
- To: Aldy Hernandez <aldyh at redhat dot com>
- Cc: Jason Merrill <jason at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 13 Dec 2011 13:02:10 -0800
- Subject: Re: PR middle-end/51411: handle transaction_safe virtual inlined methods
- References: <4EE7B85D.8020303@redhat.com> <4EE7B8CF.6040808@redhat.com> <4EE7BA39.6050900@redhat.com>
On 12/13/2011 12:48 PM, Aldy Hernandez wrote:
> PR middle-end/51411
> * trans-mem.c (ipa_tm_create_version): Do not zap DECL_EXTERNAL.
...
> /* ??? Is it worth trying to use make_decl_one_only? */
> if (DECL_DECLARED_INLINE_P (new_decl) && DECL_EXTERNAL (new_decl))
> - {
> - DECL_EXTERNAL (new_decl) = 0;
> - TREE_PUBLIC (new_decl) = 0;
> - }
> + DECL_EXTERNAL (new_decl) = 0;
Yes, that's what we had in mind. Though of course the changelog doesn't match.
r~