This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 5/6] mips: Implement vec_perm_const.
Hans-Peter Nilsson <hp@bitrange.com> writes:
> On Sun, 11 Dec 2011, Richard Sandiford wrote:
>> [Mingjie, please could you help with the Loongson question near the end?]
>
>> As H-P mentioned, this changes the __builtin_* interface for the PSHUFH
>> intrinsics. These intrinsics are supposed to be used via the inline
>> wrappers in loongson.h, so we can either keep the unused argument in
>> the pshufh_{u,s} or, as H-P suggests, remove the argument from both.
>> I don't know which is better. loongson.h needs to change either way,
>> so in the patch below, I went for the former. The latter would need
>> testsuite changes too. Mingjie, which do you think is best?
>
> Please also consider incrementing __mips_loongson_vector_rev, or
> if currently empty, set to 1. And mention PR48068 in the
> changelog; fixed in part.
For avoidance of doubt, that only applies to the latter ("as H-P
suggests") option. The patch as posted keeps the public interface
the same.
Richard