This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 5/6] mips: Implement vec_perm_const.


On Thu, 8 Dec 2011, Richard Henderson wrote:
> diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c
> index d3fd709..f1c3665 100644
> --- a/gcc/config/mips/mips.c
> +++ b/gcc/config/mips/mips.c

> @@ -13021,8 +13015,8 @@ static const struct mips_builtin_description mips_builtins[] = {
>    LOONGSON_BUILTIN (pasubub, MIPS_UV8QI_FTYPE_UV8QI_UV8QI),
>    LOONGSON_BUILTIN (biadd, MIPS_UV4HI_FTYPE_UV8QI),
>    LOONGSON_BUILTIN (psadbh, MIPS_UV4HI_FTYPE_UV8QI_UV8QI),
> -  LOONGSON_BUILTIN_SUFFIX (pshufh, u, MIPS_UV4HI_FTYPE_UV4HI_UV4HI_UQI),
> -  LOONGSON_BUILTIN_SUFFIX (pshufh, s, MIPS_V4HI_FTYPE_V4HI_V4HI_UQI),
> +  LOONGSON_BUILTIN_SUFFIX (pshufh, u, MIPS_UV4HI_FTYPE_UV4HI_UQI),
> +  LOONGSON_BUILTIN_SUFFIX (pshufh, s, MIPS_V4HI_FTYPE_V4HI_UQI),
>    LOONGSON_BUILTIN_SUFFIX (psllh, u, MIPS_UV4HI_FTYPE_UV4HI_UQI),

Looks like a brute-force (ignoring backward compatibility) fix
for PR48068 item 2.  If going that route, I'd suggest at least
increment the __mips_loongson_vector_rev.  Also, loongson.h
needs the corresponding adjustment.

(No specific interest in Loongson, FWIW.)

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]