This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[Gcov] Unbreak C++ coverage
- From: Nathan Sidwell <nathan at acm dot org>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Cc: Markus Trippelsdorf <markus at trippelsdorf dot de>
- Date: Thu, 01 Dec 2011 20:05:19 +0000
- Subject: [Gcov] Unbreak C++ coverage
I've committed this patch, which unbreaks the firefox build problem Markus
found. The problem is that the list of functions to emit coverage data is
determined before the final culling of functions that don't need emitting.
There's a circular dependency here with the cgraph machinery, and I need to look
carefully as to how that might be broken.
This does revert some of the new features I was implementing, and the xfailed
gcov test is a case of this. I decided to simply remove the tests checking
coverage object visibility, rather than augment the scan-assembler machinery.
tested on i686-pc-linux-gnu. Thanks to Markus for verifying this patch does
indeed unbreak firefox.
nathan
Attachment:
revert.diff
Description: Text document