This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix early inliner inlining uninlinable functions
- From: Richard Guenther <rguenther at suse dot de>
- To: Diego Novillo <dnovillo at google dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, Iain Sandoe <developer at sandoe-acoustics dot co dot uk>, gcc-patches Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <jh at suse dot de>, Eric Botcazou <ebotcazou at adacore dot com>
- Date: Thu, 1 Dec 2011 11:59:32 +0100 (CET)
- Subject: Re: [PATCH] Fix early inliner inlining uninlinable functions
- References: <alpine.LNX.2.00.1110281455210.26779@zhemvz.fhfr.qr> <C75194BF-4970-4C98-A66F-46FF48B4EFFE@sandoe-acoustics.co.uk> <CAD_=9DThnc5n8u7nV3JQe=nxx4qpKnm7BrXLL3xxhsxunxDUBw@mail.gmail.com> <CAD_=9DRAJGWSmYS6RaNV89tDrSQWOs6qZiY6Yghqc3eTNTqDAQ@mail.gmail.com> <CAMe9rOoUkU54pELLGD71cJqPjh6ehwJGn9vsyXWjC6ieY5=MGA@mail.gmail.com> <CAD_=9DSO9aqcwfSfXsTO2EH7UB_Cb7J6v--y+PAtr0wuBy47iQ@mail.gmail.com>
On Tue, 29 Nov 2011, Diego Novillo wrote:
> On Tue, Nov 29, 2011 at 12:49, H.J. Lu <hjl.tools@gmail.com> wrote:
>
> > This caused:
> >
> > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51346
>
> Thanks. I'm on it.
The patch was wrong, please revert it. At the gimple stmt
modification level we shouldn't modify the cgraph. That's
a layering violation at least.
Please file a bug with a reduced testcase that still fails
without your fix.
Richard.