This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Ping] RE: CR16 Port addition


Hi Jayant,

> Sorry, I had not gone well through the libgcc related changes in GCC-4.7. 
> Hence I missed moving rest of the libgcc routines to top level libgcc 
> directory.

I noticed a couple of minor issues in the libgcc changes: 

* LIB1ASMSRC is relative to libgcc/config, and the file is called
  lib1funcs.S.  Please change the patch accordingly.

* gcc/config.gcc uses cr16-*-elf as target, while libgcc/config.host has
  cr16-*-*.  Please use the former in libgcc, too, and add to
  extra_parts which already has crtbegin.o crtend.o for all *-*-elf
  targets.

* It seems highly unfortunate that cr16 has its own copy of the
  unwinder, apparently even containing some references to ia64 which are
  certainly inapproprate here.  Given the amount of copy&paste
  programming within the gcc tree, is there any way to make cr16
  specific changes to the generic versions of this code?

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]