This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, take 2] Fix PR tree-optimization/49960 ,Fix self data dependence
On Mon, Nov 21, 2011 at 04:54:09PM +0200, Razya Ladelsky wrote:
> Although compute_affine_dependence() can't do anything meaningful for the
> gather data refs,
> it may still be assigning values to the dependence relation structure, if
> you need to use them.
> Therefore I did not skip the call to compute_self_dependence(), which
> indeed calls
> compute_affine_depepndence().
>
>
> If you think it's redundant, we can remove it.
It is not just redundant, but harmful. compute_affine_dependence assumes
that base and offset are simple IVs, that is not true for gather deps.
So please do remove it.
Jakub
- References:
- [PATCH, take 2] Fix PR tree-optimization/49960 ,Fix self data dependence
- Re: [PATCH, take 2] Fix PR tree-optimization/49960 ,Fix self data dependence
- Re: [PATCH, take 2] Fix PR tree-optimization/49960 ,Fix self data dependence
- Re: [PATCH, take 2] Fix PR tree-optimization/49960 ,Fix self data dependence
- Re: [PATCH, take 2] Fix PR tree-optimization/49960 ,Fix self data dependence