Re: [Patch] make it possible for the target to rename ".tm_clone_table"

[Iain Sandoe <developer at sandoe-acoustics dot co dot uk>]

Hi Richard,

On 19 Nov 2011, at 18:43, Richard Henderson wrote:

> On 11/19/2011 02:04 AM, Iain Sandoe wrote:
> > It should be possible for Rainer to define
> > TARGET_ASM_TM_CLONE_TABLE_SECTION_NAME to NULL, and have varasm use
> > the normal data section for tm_clone_table sections.    One might
> > wish to re-adjust testsuite/gcc.dg/tm/20100615.c if that is done.
>
> Well, not really.  OSF is going to need an extension to collect2 in
> order to create a single table, or changes to other bits of the
> compiler to invoke _ITM_registerTMCloneTable for each object file's
> table.
>
> ... actually, there seems to be some sort of merge error.  I don't
> see the crtstuff.c changes that called _ITM_registerTMCloneTable in
> the first place.

This might go some way to explaining my confusion  :-)
.. I did try to find any other reference to .tm_clone_table in the  
code and failed ...

(varasm.c and the testsuite entry are the only two refs I can see).

> I'd prefer we return a section object instead.  I.e. pull the
> call to get_named_section into the hook as well.

as per attached?
Iain


gcc:

	* target.def (tm_clone_table_section): New hook.
	* doc/tm.texi.in (TARGET_ASM_TM_CLONE_TABLE_SECTION): Define.
	* doc/tm.texi: Regenerate.
	* varasm.c (dump_tm_clone_pairs): Use target tm_clone_table_section.
	* config/darwin.h (TARGET_ASM_TM_CLONE_TABLE_SECTION): New.
	* config/darwin-protos.h (darwin_tm_clone_table_section): New  
prototype.
	* config/darwin.c (darwin_tm_clone_table_section): New.

gcc/testsuite:

	* gcc.dg/tm/20100615.c: Adjust for Darwin tm_clone_table section name.

Attachment: 181530-tm-clone-tab-v3.txt
Description: Text document