This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Disable libitm if unsupported


Hi Chaps....

On 8 Nov 2011, at 18:22, Richard Henderson wrote:

On 11/08/2011 09:56 AM, Pedro Alves wrote:
On Tuesday 08 November 2011 17:31:45, Richard Henderson wrote:
On 11/08/2011 09:26 AM, Pedro Alves wrote:
On Tuesday 08 November 2011 16:33:52, Richard Henderson wrote:
toplevel/
* configure.ac: Adjust srcdir for running libitm/ configure.tgt.

+# Disable libitm on unsupported hosted systems.
+if test x$enable_libitm = x; then
+   AC_MSG_CHECKING([for libitm support])
+   if (srcdir=${srcdir}/libitm; \
+       . ${srcdir}/configure.tgt; \

This should check that libitm exists before sourcing the script, as otherwise it will error out on src tree checkouts (binutils, gdb, ...), given that the libitm directory doesn't exist there.

Should I bother with an explicit test, or just use "set -e"?

Whatever works is fine with me. :-)



Tested and committed the following.

is it expected for libitm to work on x86 darwin? (the implication of the libitm/configure.tgt is yes .. )

.. can't seem to get it to build ..

/bin/sh ./libtool --tag=CXX --mode=compile -B/GCC/gcc-4-7-install/ i686-apple-darwin9/bin/ -B/GCC/gcc-4-7-install/i686-apple-darwin9/lib/ -isystem /GCC/gcc-4-7-install/i686-apple-darwin9/include -isystem /GCC/ gcc-4-7-install/i686-apple-darwin9/sys-include -DHAVE_CONFIG_H -I. - I/GCC/gcc-live-trunk/libitm -I/GCC/gcc-live-trunk/libitm/config/posix -I/GCC/gcc-live-trunk/libitm/config/generic -I/GCC/gcc-live-trunk/ libitm -std=gnu++0x -funwind-tables -fno-exceptions -fno-rtti - march=i486 -mtune=i686 -fomit-frame-pointer -Wall -Werror -Wc,- pthread -fabi-version=4 -g -O2 -MT cacheline.lo -MD -MP -MF .deps/ cacheline.Tpo -c -o cacheline.lo /GCC/gcc-live-trunk/libitm/config/ generic/cacheline.cc
libtool: compile: unrecognized option `-B/GCC/gcc-4-7-install/i686- apple-darwin9/bin/'
libtool: compile: Try `libtool --help' for more information.
make[3]: *** [barrier.lo] Error 1


Iain


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]