This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Re: [Ping] RE: CR16 Port addition


On Fri, 4 Nov 2011, Jayant R. Sonar wrote:

> Ping 5: For review
> 
> Can someone please review the modified patch:
> http://gcc.gnu.org/ml/gcc-patches/2011-10/msg01985.html

You still have a spurious change to libstdc++-v3/configure without any 
corresponding change to a source file generating that file.  Remove that 
change.

Your toplevel configure.ac change is inappropriate.  Targets should no 
longer add ${libgcj} to noconfigdirs.  If some targets support GDB but 
others don't then the cases should look something like

  cr16-*-uclinux)
    ;;
  cr16-*-*
    noconfigdirs="$noconfigdirs gdb"
    ;;

to achieve the desired effect - *but* this would go in as part of the GDB 
port, not the GCC port.  So remove the change to toplevel configure.ac 
completely.

You're adding a file gcc/config/cr16/unwind-dw2-cr16.c, and unwind-dw2.h.  
All libgcc sources go in under the toplevel libgcc/ directory now.

You have a lot of logic related to libgcc in gcc/config/cr16/t-cr16.  
Because this logic has now moved to the toplevel libgcc directory, you'll 
need to update the patch for those changes.  Likewise extra_parts in 
config.gcc.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]