This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] 1/n: trans-mem: libitm runtime tests


On Thu, Nov 03, 2011 at 05:26:43PM -0500, Aldy Hernandez wrote:
> >I'm going to assume the tests themselves are good.  It'd be nice if
> >they all stated what they were testing, but I don't consider that a
> >requirement.  If the tests were written independently rather than
> >extracted from another blob of code, you may consider adding a
> >copyright notice to them.
> 
> Hmm, we based a lot of the original skeleton from libgomp, and
> AFAICT only one test has a copyright notice:
> 
> 	libgomp.c/sort-1.c
> 
> If you feel strongly about this, I can add a copyright notice to
> every test, after I finish all the other recommendations elsewhere.

The reason for the copyright notice in there is that at that time
I felt the test was already quite big, but looking at it now
there are many even bigger tests in libgomp testsuite.  And most
of the libgomp tests (except for appendix-a/ tests) were written
independently.
In libstdc++-v3/testsuite it seems most of the tests have the notice
(including very small ones), elsewhere most of the tests don't have
anything at all.
So I would say if the test is really small, it isn't worth adding it
there, perhaps only for very large tests.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]