This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] Cleanup of gfc_extend_expr
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: Janus Weil <janus at gcc dot gnu dot org>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 2 Nov 2011 23:52:17 +0100
- Subject: Re: [Patch, Fortran] Cleanup of gfc_extend_expr
- References: <CAKwh3qgZc8ybyvu+8a7MUC9a9Jyxp8Ux5-vhO-hD=66AOwimKQ@mail.gmail.com>
On Wed, Nov 2, 2011 at 11:17 PM, Janus Weil <janus@gcc.gnu.org> wrote:
> What the patch does is to change the return value from
> 'gfc_try' (SUCCESS/FAILURE) to 'match'
> (MATCH_YES/MATCH_NO/MATCH_ERROR). Of course we're not really
> 'matching' anything here, but the yes/no/error range of values is
> exactly what we need in this case, so I think (ab-)using the 'match'
> enum makes sense.
I don't like that at all. Sooner or later that's going to confuse
someone. There has to be a better solution...
Ciao!
Steven