This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: resent2 [PATCH] Fix ICE in redirect_jump, at jump.c:1497 PR50496
- From: Bernd Schmidt <bernds at codesourcery dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: Chung-Lin Tang <cltang at codesourcery dot com>, Markus Trippelsdorf <markus at trippelsdorf dot de>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 02 Nov 2011 16:47:05 +0100
- Subject: Re: resent2 [PATCH] Fix ICE in redirect_jump, at jump.c:1497 PR50496
- References: <20111014085134.GA1662@x4.trippels.de> <4EA5A8C2.7060505@codesourcery.com> <4EAE6045.7070201@codesourcery.com> <201110311011.05280.ebotcazou@adacore.com>
On 10/31/11 10:11, Eric Botcazou wrote:
>> I'm suggesting a new patch, as attached. Before reload_completed, we
>> directly return 0 upon nlabel == NULL, which should be identical with
>> old behavior, while asserting fail if after reload (where we assume the
>> simple_return/return distinction is required).
>>
>> This should ensure better that, if a post-prologue case of redirecting
>> to the exit block ever happens we will more easily know (by some future
>> PR :P)
>>
>> Bootstrapped and tested on i686, and cross tested on ARM using QEMU.
>> Eric, is this approach okay?
>
> Don't you want epilogue_completed instead of reload_completed? Otherwise,
> yes, the approach is fine with me, but wait for Bernd's input.
That looks good to me too.
Bernd