This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/7] Emit macro expansion related diagnostics

On 10/13/2011 01:12 PM, Dodji Seketeli wrote: 
+  while (true)
+    {
+      if (!linemap_macro_expansion_map_p (map0)
+         || !linemap_macro_expansion_map_p (map1)
+         || map0 == map1)
+       break;

I'd put the test in the condition, but if you find it clearer this way, I guess that's fine. Let's go ahead and check all this in.

Jason

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]