This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix stack red zone bug (PR38644)
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Jiangning Liu <jiangning dot liu at arm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, jh at suse dot cz, geoffk at geoffk dot org, dje dot gcc at gmail dot com, rth at redhat dot com, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Matthew Gretton-Dann <Matthew dot Gretton-Dann at arm dot com>
- Date: Wed, 28 Sep 2011 09:07:54 +0200
- Subject: Re: [PATCH] Fix stack red zone bug (PR38644)
- References: <4e8136c8.54cee30a.074d.5d06SMTPIN_ADDED@mx.google.com> <CAFULd4YqfRyLwSkAHq2SueN=TxDrnyApbvUvSiJn9PTO7UhZTw@mail.gmail.com> <4e82c1f5.89cae30a.4548.7372SMTPIN_ADDED@mx.google.com>
On Wed, Sep 28, 2011 at 8:42 AM, Jiangning Liu <jiangning.liu@arm.com> wrote:
> Just realized ChangeLog needs to be changed as well.
>
> ChangeLog:
>
> ? ? ? ?* config/i386/i386.c (ix86_using_red_zone): Remove inline.
> ? ? ? ?(TARGET_STACK_USING_RED_ZONE): New.
> ? ? ? ?* config/rs6000/rs6000.c (rs6000_stack_using_red_zone): New.
> ? ? ? ?(TARGET_STACK_USING_RED_ZONE): New.
> ? ? ? ?(offset_below_red_zone_p): Change to use new hook
> ? ? ? ?TARGET_STACK_USING_RED_ZONE.
> ? ? ? ?* doc/tm.texi (TARGET_STACK_USING_RED_ZONE): New.
> ? ? ? ?* doc/tm.texi.in (TARGET_STACK_USING_RED_ZONE): New.
> ? ? ? ?* sched-deps.c (sched_analyze_1): If the stack pointer is being
> ? ? ? ?modified and stack red zone is not supported for ports, flush out
> ? ? ? ?all memory references as they may become invalid if moved across
> ? ? ? ?the stack adjustment.
> ? ? ? ?* target.def (stack_using_red_zone): New.
> ? ? ? ?* testsuite/gcc.target/arm/stack-red-zone.c: New.
OK for x86, but you need approval from middle-end maintainer for the patch.
Thanks,
Uros.