This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [google] Linker plugin to do function reordering using callgraph edge profiles (issue5124041)


On Sat, 24 Sep 2011 10:00:37 -0400, Diego Novillo wrote:

> On 11-09-24 09:37 , Michael Witten wrote:
>>> Re: [google] Linker plugin to do function reordering...
>>
>> Is there a particularly good reason for why you guys
>> slip `[google]' into all of your `Subject:' lines?
>
> Yes, labels in brackets tend to be markers for branches, version 
> numbers, specific modules.  In this case, they're used to indicate 
> patches to one of the google branches (http://gcc.gnu.org/svn.html, 
> http://gcc.gnu.org/ml/gcc/2011-01/msg00246.html).

>From that email:

> google/integration
>    A branch following trunk that contains some minimal patches that
> are likely not useful anywhere outside of Google's build environment.
> These are typically configuration patches.

Why is gnu.gcc.org hosting work that is specific to some company's
build system?

> google/main
>    A branch of google/integration that contains Google local patches
> that we are looking to contribute to trunk.  Some of these patches are
> either in the process of being reviewed, or have not yet been
> proposed.  The intent of this branch is to serve as a staging platform
> to allow collaboration with external developers.  Patches in this
> branch are only expected to remain here until they are reviewed and
> accepted in trunk.

Why is it necessary to announce a patch [series] for this branch when it
is intended that such a patch [series] make it to the trunk? Shouldn't an
employee of your company submit a `trunk'-worthy patch [series] for review
as would anyone else?

Isn't having one branch named `google' (or `google/maint') too ridiculously
generic to be of any use whatsoever? Wouldn't it make far more sense to have
a topic branch if deemed necessary (for, say, a large patch series)?

Why is gnu.gcc.org hosting such a pointless branch? Is it just that the
technical inadequacies of SVN made it easier for your multi-billion-dollar
company to host its essentially private work in GNU's repository?

Furthermore, looking at the `Subject' header of this email:

  Subject: Re: [google] Linker plugin to do function reordering using
                        callgraph edge profiles (issue5124041)

I wonder what `issue5124041' means. Is that a reference that only has
meaning for employees of your company?

Sincerely,
Michael Witten


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]