This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Cary Coutant <ccoutant at google dot com>, Ian Lance Taylor <iant at google dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 23 Sep 2011 09:49:28 +0200
- Subject: Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)
- References: <CAHACq4qJ+yxHixtf_xud+rphr4N2=Qwbv3mS=YC2ezzfwiw6Yg@mail.gmail.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Sep 22, 2011 at 05:40:15PM -0700, Cary Coutant wrote:
> > Ping?
> >
> > http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01626.html
It looks good to me, but I'd prefer if Ian with his demangler author
and libiberty maintainer hats looked at it too.
> > include/ChangeLog:
> >
> > ? ? ? ?PR 40831
> > ? ? ? ?* demangle.h (enum demangle_component_type): Add
> > ? ? ? ?DEMANGLE_COMPONENT_CLONE.
> >
> > libiberty/ChangeLog:
> >
> > ? ? ? ?PR 40831
> > ? ? ? ?* cp-demangle.c (d_make_comp): Add new component type.
> > ? ? ? ?(cplus_demangle_mangled_name): Check for clone suffixes.
> > ? ? ? ?(d_parmlist): Don't error out if we see '.'.
> > ? ? ? ?(d_clone_suffix): New function.
> > ? ? ? ?(d_print_comp): Print info for clone suffixes.
> > ? ? ? ?* testsuite/demangle-expected: Add new testcases.
Maybe the testcase should test also
_Z2f1IiEvT_S0_S0_._omp_fn.2
_Z3fooi._omp_cpyfn.6
as examples of OpenMP suffixing - the former is an example of name
used for outlined #pragma omp {parallel,task} region from a function
and the latter is for copy constructors needed for #pragma omp task.
Jakub