Re: [PATCH 3/7] Emit macro expansion related diagnostics

[Jason Merrill <jason at redhat dot com>]

On 09/21/2011 02:32 PM, Dodji Seketeli wrote:
> FWIW, I'd like the LRK_MACRO_PARM_REPLACEMENT name (or its
> replacement.  ha ha) to hint at the fact that it really has to do with
> a token that is an /argument/ for a function-like macro.

I disagree; arguments are the situation when the two locations differ, 
but this one (yI) is always the source location in the macro definition, 
while the first one (xI) is either that or, for macro arguments, a 
virtual location.  So the association with arguments seems backwards to me.

> So would a function named linemap_macro_map_loc_to_def_point that
> returns the second location (yI) only, and a second function
> linemap_macro_map_loc_unwind_once be less confusing to you?

Yes, that sounds good.

Jason