This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] PR 41733: Proc-pointer conformance checks: Elemental-proc-ptr => non-elemental-proc
Hi Steve,
>> The patch was regtested on x86_64-unknown-linux-gnu. Ok for trunk?
>>
>
> OK.
thanks for the review!
> The only nitpicking that I have is with Nonintrinsic in
>
> + ? ? ? ? gfc_error ("Nonintrinsic elemental procedure '%s' is invalid "
> + ? ? ? ? ? ? ? ? ? ?"in procedure pointer assigment at %L",
> + ? ? ? ? ? ? ? ? ? ?rvalue->symtree->name, &rvalue->where);
>
>
> I would probably use Non-intrinsic.
Since you're a native speaker and I'm not, I would of course trust
your judgement here more than my own. And indeed
oxforddictionaries.com as well as a simple Google search seems to
agree with you (although
http://oxforddictionaries.com/definition/non-?rskey=ylflNy&result=3
also lists non-dash versions for some words, pun intended ;)
However, both F03 and F08 spell it as:
"C730 (R740) The proc-target shall not be a nonintrinsic elemental procedure."
While the Fortran standard is the authoritative document on Fortran
issues, it is certainly not the authoritative document on spelling
issues. However, I still think keeping our error messages close to the
standard is a good thing in general, so using the same spelling should
be at least "acceptable".
I don't have a strong opinion on this, but I would just commit the
patch as is, if you don't mind ...
If anyone really cares, you could set off a "bug report" to the
Fortran standards committee ;)
Cheers,
Janus