This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [pph] Remove XPASS noise from pph testsuite (issue4967063)
- From: Gabriel Charette <gcharette1 at gmail dot com>
- To: Diego Novillo <dnovillo at google dot com>
- Cc: reply at codereview dot appspotmail dot com, crowl at google dot com, gcc-patches at gcc dot gnu dot org
- Date: Mon, 12 Sep 2011 10:51:15 -0400
- Subject: Re: [pph] Remove XPASS noise from pph testsuite (issue4967063)
- References: <20110912114045.B95911DA1D9@topo.tor.corp.google.com>
Oops forgot to reply all...
On Mon, Sep 12, 2011 at 7:40 AM, Diego Novillo <dnovillo@google.com> wrote:
> This patch removes all the XPASS noise from pph.exp runs by pruning
> the output from the base compiles (thanks Ian for the pointer). It
> add some comments as well.
>
> Lawrence, I noticed that we do not seem to need -I. -fno-dwarf2-cfi-asm
> anymore. So, I removed them. I'm not sure I remember exactly why you
> had added them, but since removing them produces no changes to the
> results, I just took them out.
This was a hack because Lawrence was getting different asm checksums
for the pph asm xdiff because his configuration would output some
additional dwarf2-cfi assembly. Thus, no single expected diff checksum
would work for both of us.
Cheers,
Gab