This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[testsuite,committed]: Fix gcc.dg/ipa/ipcp-3.c
- From: Georg-Johann Lay <avr at gjlay dot de>
- To: gcc-patches at gcc dot gnu dot org
- Cc: Georg-Johann Lay <avr at gjlay dot de>, Martin Jambor <mjambor at suse dot cz>
- Date: Mon, 05 Sep 2011 16:02:39 +0200
- Subject: [testsuite,committed]: Fix gcc.dg/ipa/ipcp-3.c
- References: <4E64BBB2.20602@gjlay.de> <20110905124112.GA27430@virgil.arch.suse.de>
Committed as obvious.
http://gcc.gnu.org/viewcvs?view=revision&revision=178545
Martin Jambor schrieb:
> Hi,
>
> On Mon, Sep 05, 2011 at 02:08:18PM +0200, Georg-Johann Lay wrote:
>> This test case contains expression 1 << 18 which leads to FAIL for targets with
>> sizeof(int) < 4.
>>
>> The mask seems not to be relevant for the test and can be set to, e.g. 14.
>>
>
> I have created the testcase by modifying the one for PR 43835
> (testsuite/gcc.c-torture/execute/pr43835.c), the shift could probably
> be removed from the test altogether (but of course shift by 14 is also
> fine with me, though I cannot approve anything). I'm just wondering
> what kind of failure this causes (a compile time one?) and why that
> same failure does not take place with the aforementioned pr43835.c
> testcase...
>
> BTW, unfortunately I have recently also added a bunch of such shifts
> in testsuite/gcc.c-torture/execute/pr49886.c, are they OK?
>
> Thanks,
>
> Martin
>
>
>> Ok?
>>
>> testsuite/
>> * gcc.dg/ipa/ipcp-3.c (mark_cell): Use mask 1 << 14 instead of 1 << 18.
>>
>>
>>
>> Index: gcc.dg/ipa/ipcp-3.c
>> ===================================================================
>> --- gcc.dg/ipa/ipcp-3.c (revision 178527)
>> +++ gcc.dg/ipa/ipcp-3.c (working copy)
>> @@ -34,7 +34,7 @@ static void
>> mark_cell(int * interp, Pcc_cell *c)
>> {
>> if (c && c->type == 4 && c->p
>> - && !(c->p->flags & (1<<18)))
>> + && !(c->p->flags & (1<<14)))
>> never_ever(interp, c->p);
>> }
>>