This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH, ARM, iWMMXt][1/5]: ARM code generic change
- From: Xinyu Qi <xyqi at marvell dot com>
- To: Ramana Radhakrishnan <ramana dot radhakrishnan at linaro dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 17 Aug 2011 19:06:31 -0700
- Subject: RE: [PATCH, ARM, iWMMXt][1/5]: ARM code generic change
> -----Original Message-----
> From: Ramana Radhakrishnan [mailto:ramana.radhakrishnan@linaro.org]
At 2011-08-18 09:29:34,"Ramana Radhakrishnan" <ramana.radhakrishnan@linaro.org> wrote:
> Hi ,
>
> Sorry about the delayed review - It's taken me a while to get back to this .
>
> On 14 July 2011 08:35, Xinyu Qi <xyqi@marvell.com> wrote:
> >> > Hi,
> >> >
> >> > It is the first part of iWMMXt maintenance.
> >> >
> >> > *config/arm/arm.c (arm_option_override):
> >> > ? Enable iWMMXt with VFP. iWMMXt and NEON are incompatible.
> >> iWMMXt unsupported under Thumb-2 mode.
> >> > ? (arm_expand_binop_builtin): Accept immediate op (with mode VOID)
> >> > *config/arm/arm.md:
> >> > ? Resettle include location of iwmmxt.md so that *arm_movdi
> >> and *arm_movsi_insn could be used when iWMMXt is enabled.
>
> This is OK modulo the Changelog entry.
>
> Please write this as :
>
> <TAB>* config/arm/arm.c (arm_option_override): Enable use of iwMMXt
> with VFP. Disable use of iwMMXt and Neon.
> <TAB>* config/arm/arm.md (iwmmxt.md): Include earlier.
> (*arm_movsi_insn): Remove check for TARGET_IWMMXT.
> (*arm_movdi_insn): Likewise.
>
>
> cheers
> Ramana
Thanks for reviewing!
I remember updating the patch stack according to your previous comment several weeks ago.
http://gcc.gnu.org/ml/gcc-patches/2011-07/msg01100.html
http://gcc.gnu.org/ml/gcc-patches/2011-07/msg01101.html
http://gcc.gnu.org/ml/gcc-patches/2011-07/msg01103.html
http://gcc.gnu.org/ml/gcc-patches/2011-07/msg01105.html
http://gcc.gnu.org/ml/gcc-patches/2011-07/msg01106.html
The new ChangLog for this part:
*config/arm/arm.c (arm_option_override): Enable use of iWMMXt with VFP. Disable use of iwMMXt and Neon.
(arm_expand_binop_builtin): Accept VOIDmode op.
*config/arm/arm.md (*arm_movdi, *arm_movsi_insn): Remove check for TARGET_IWMMXT.
(iwmmxt.md): Include earlier.
Thanks,
Xinyu