This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [lto] Remove most streamer hooks. (issue4863041)
- From: Michael Matz <matz at suse dot de>
- To: Diego Novillo <dnovillo at google dot com>
- Cc: reply at codereview dot appspotmail dot com, rguenther at suse dot de, jh at suse dot cz, gcc-patches at gcc dot gnu dot org
- Date: Thu, 11 Aug 2011 14:23:04 +0200 (CEST)
- Subject: Re: [lto] Remove most streamer hooks. (issue4863041)
- References: <20110811023759.D405D1DA19F@topo.tor.corp.google.com>
Hi,
On Wed, 10 Aug 2011, Diego Novillo wrote:
> The API in the tree streamer offers functions to read/write the
> tree header and the body, a streamer cache and everything that
> used to be inside the LTO streamer. This makes no difference to
> LTO, since it simply means that some formerly static functions are
> now extern functions in tree-streamer*.
>
> The only big change for LTO is mechanical. The low-level
> pickling/unpickling routines in the tree streamer need to call the
> write_tree and read_tree hooks instead of
> lto_output_tree/lto_input_tree. So, the bulk of this patch are
> calls to stream_write_tree and stream_read_tree (two macros that
> expand to streamer_hooks.write_tree and streamer_hooks.read_tree).
The obvious question: have you measured performance (with an optimized
cc1) on a medium sized exectutable, say cc1 itself? (I'm worrying about
inlining that doesn't happen anymore).
Ciao,
Michael.