This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR47566
- From: Richard Henderson <rth at redhat dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: Richard Guenther <rguenther at suse dot de>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 22 Jul 2011 10:28:26 -0700
- Subject: Re: [PATCH] Fix PR47566
- References: <201107221719.p6MHJwCO026636@d06av02.portsmouth.uk.ibm.com>
On 07/22/2011 10:19 AM, Ulrich Weigand wrote:
> Richard Henderson wrote:
>> On 07/22/2011 07:42 AM, Ulrich Weigand wrote:
>>> Well, it works for me with just adding -lm to the dg-extra-ld-options.
>>> This still folds cabs to sqrt in the LTO step, and then satisfies that
>>> call via the libm routine ... If I understood your intent correctly,
>>> this should still test the same thing, shouldn't it?
>>
>> Not quite, since -lm also provides cabs.
>
> Well, yes (mine does as well). But the -O2 LTO step will still fold cabs
> to sqrt instead of pulling in the cabs from the library, at least it does
> for me. Thus the test still verifies this folding doesn't crash, which
> is what I understood it should do. Am I missing something?
Oops, sorry. I forgot we were testing for a crash, not verifying the fold.
r~