This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/3] Remove code that supported legacy CLooG.


On 07/22/2011 01:46 AM, Sebastian Pop wrote:
On Thu, Jul 21, 2011 at 18:00, Tobias Grosser<tobias@grosser.es> wrote:
  static void
  create_params_index (htab_t index_table, CloogProgram *prog) {
-  CloogNames* names = cloog_program_names (prog);
-  int nb_parameters = cloog_names_nb_parameters (names);
-  char **parameters = cloog_names_parameters (names);
+  CloogNames* names = prog->names;

Please also fix the formatting here: CloogNames *names = prog->names;

The rest of the patch looks good.  Before checking in, please wait for a
configure maintainer to approve the config changes.

Thanks for the review. I will obviously wait for the OK of a configure maintainer.


Tobi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]