Re: [PATCH, MELT] Add PRE_GENERICIZE callback support in MELT

[Pierre Vittet <piervit at pvittet dot com>]

Right, here is the new version of the patch (with the correct files).

I added, a function register_pre_genericize_hook in 
melt/warmelt-base.melt to be called when we want to register a MELT 
function to handle the callback, so we don't manually set 
sysdata_pre_genericize field.

Pierre Vittet

On 15/07/2011 18:41, Romain Geissler wrote:
> Le 15 juil. 2011 à 18:17, Pierre Vittet a écrit :
>
>    
> > Hello,
> >
> > The following patch add support for PLUGIN_PRE_GENERICIZE callback.
> >
> > The add_sysdata_pre_genericize patch add a field (sysdata_pre_genericize) in initial system data, allowing to register a closure to be called on PLUGIN_PRE_GENERICIZE event. This patch must be first applied and a make warmelt-upgrade must be run in order to regenerate generated melt files.
> >
> > The add_pre_genericize_hook patch add a function (in melt-runtime.c) to be called on PLUGIN_PRE_GENERICIZE, which call the closure sysdata_pre_genericize defined by the users.
> >
> > Thanks
> >
> > Pierre Vittet
> > <add_sysdata_pre_genericize-176032.ChangeLog><add_sysdata_pre_genericize-176032.diff><add_pre_genericize_hook-176032.ChangeLog><add_pre_genericize_hook-176032.ChangeLog~>
> >      
> Great !
>
> You forgot to attach the patch for melt-runtime.c (there is only the changelog)
>
> I know your performing some simple static analysis, mostly based on matching some c source code patterns (check that there is a if (fopen_result) just after a fopen.
>
> Is there a particular reason to do that as a pass (so at the gimple level) rather that doing it just after the function has been parsed (eg upon PLUGIN_PRE_GENERICIZE) ?
>
>

Attachment: add_sysdata_pre_genericize-176032.ChangeLog
Description: Text document

Attachment: add_sysdata_pre_genericize-176032.diff
Description: Text document

Attachment: add_pre_genericize_hook-176032.ChangeLog
Description: Text document

Attachment: add_pre_genericize_hook-176032.diff
Description: Text document