This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PING] [PATCH, libstdc++-v3] Add newlib specific ctype_members.cc
- From: "Yufeng Zhang" <Yufeng dot Zhang at arm dot com>
- To: "'Paolo Carlini'" <paolo dot carlini at oracle dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>, <libstdc++ at gcc dot gnu dot org>
- Date: Fri, 15 Jul 2011 18:30:47 +0100
- Subject: RE: [PING] [PATCH, libstdc++-v3] Add newlib specific ctype_members.cc
- References: <000001cc246f$72b81c20$58285460$@Zhang@arm.com> <001601cc31c4$2c367820$84a36860$@Zhang@arm.com> <4E08B9A0.50301@oracle.com> <000801cc3810$4cab51f0$e601f5d0$@Zhang@arm.com>
Hi Paolo,
> -----Original Message-----
> From: gcc-patches-owner@gcc.gnu.org [mailto:gcc-patches-
> owner@gcc.gnu.org] On Behalf Of Yufeng Zhang
> Sent: 01 July 2011 18:00
> To: 'Paolo Carlini'
> Cc: gcc-patches@gcc.gnu.org; libstdc++@gcc.gnu.org
> Subject: RE: [PING] [PATCH, libstdc++-v3] Add newlib specific
> ctype_members.cc
>
> Hi Paolo,
>
> Thank you for the review.
>
> > > Ping for:
> > > http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00440.html
> > personally, I have only minor comments, like only 2011 as Copyright
> > year for new files, and please also regtest on a gnu-linux system.
>
> I've updated the Copyright year and removed the regenerated file from
> the patch. The updated patch is attached.
>
> I've also run the regtest on x86_64-linux-gnu.
>
> > Before going ahead, however, you should send the patch also to the
> > libstdc++ mailing list (this is the rule for v3 patches) and make
> sure
> > the other maintainers don't have further comments. Wait, say, at
> least
> > a couple of days.
>
> Sorry for missing the rule previously. I sent the patch to the
> libstdc++
> mailing list yesterday; see
> http://gcc.gnu.org/ml/libstdc++/2011-06/msg00091.html
> I've also added the mailing list to the CC list. I'll wait a few days
> to see if there is any more comment.
There is no more comment received. I wonder if it is OK to get the patch
committed. I have write after approval to GCC, but I'm not sure if that
applies to libstdc++-v3 or not. If you think the patch is OK, can you
please help me commit it? If you think I can/shall commit it by myself,
please let me know.
Thanks,
Yufeng
P.S. I have re-verified the patch on the tip of the trunk today.