This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [Annotalysis] Fix to get_canonical_lock_expr
- From: Diego Novillo <dnovillo at google dot com>
- To: Delesley Hutchins <delesley at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Le-Chun Wu <lcwu at google dot com>
- Date: Tue, 12 Jul 2011 19:25:36 -0400
- Subject: Re: [PATCH] [Annotalysis] Fix to get_canonical_lock_expr
- References: <CAF6KqwWv4Sj6BnxEKA5HD_0h3iUUVb2JseV7MtFXJGxQU=WTNA@mail.gmail.com>
On 11-07-11 18:53 , Delesley Hutchins wrote:
This patch fixes get_canonical_lock_expr so that it works on lock
expressions that involve a MEM_REF. Gimple code can use either
MEM_REF or INDIRECT_REF in many expressions, and the choice of which
to use is somewhat arbitrary. The canonical form of a lock expression
must rewrite all MEM_REFs to INDIRECT_REFs to accurately compare
expressions. The surrounding "if" block prevented this rewrite from
happening in certain cases.
Bootstrapped and passed GCC regression testsuite on x86_64-unknown-linux-gnu.
Okay for branches/annotalysis and google/main?
Remember
-DeLesley
2011-07-06 DeLesley Hutchins<delesley@google.com>
* cp_get_virtual_function_decl.c (handle_call_gs): Changes
function to return null if the method cannot be found.
> 2011-07-11 DeLesley Hutchins<delesley@google.com>
> * tree-threadsafe-analyze.c (tree-threadsafe-analyze.c)
> Changed to force rewrite on MEM_REF
You keep forgetting a blank line after the date line :)
Needs a ':' after ')', and the sentence should end in '.'.
The change description does not seem to be related to the change in the
code.
OK, otherwise.
Diego.