This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix bootstrap on OpenBSD, PR48851


On Mon, Jul 4, 2011 at 8:51 AM, Richard Guenther <rguenther@suse.de> wrote:
> On Mon, 4 Jul 2011, Bruce Korb wrote:
>
>> Hi Richard,
>>
>> On Mon, Jul 4, 2011 at 4:04 AM, Richard Guenther <rguenther@suse.de> wrote:
>> >
>> > It happens that OpenBSD suffers from a bogus fixinclude that changes
>> > its perfectly valid NULL define from (void *)0 to 0. ?The fix itself
>> > appears to be very old and is completely bogus - it replaces
>> > (void *)0 with 0 under the assumption the former is invalid for C++ -
>> > which is true - but 0 is inappropriate for C which is much worse.
>> >
>> > Thus, I propose to remove the fix altogether. ?Platform maintainers
>> > can arrange for a new fix if the platforms still need fixing (which
>> > I seriously doubt after so many years and platform obsoletion).
>> >
>> > This restores bootstrap on OpenBSD.
>> >
>> > Ok for trunk and active branches?
>>
>> Sounds completely reasonable to me, but I think the platform maintainers
>> do need to say, "okay". ?Cheers - Bruce
>
> We do not have an Interix maintainer listed, that leaves David for AIX.
> David, is this ok? ?If not, can you please work on a better more
> specific fixinclude wrapping the C++ variant inside __GNUG__?

Okay with me.

Thanks, David


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]