This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Ping #1: [Patch, AVR]: Fix PR34734


2011/6/29 Georg-Johann Lay <avr@gjlay.de>:
> Denis Chertykov wrote:
>> 2011/6/28 Georg-Johann Lay <avr@gjlay.de>:
>>> http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01462.html
>>>
>>> Georg-Johann Lay wrote:
>>>> PR34734 produces annoying, false warnings if __attribute__((progmem))
>>>> is used in conjunction with C++. ÂDECL_INITIAL is not yet set up in
>>>> avr_handle_progmem_attribute.
>>>>
>>>> Johann
>>>>
>>>> Â Â Â PR target/34734
>>>> Â Â Â * config/avr/avr.c (avr_handle_progmem_attribute): Move warning
>>>> Â Â Â about uninitialized data attributed 'progmem' from here...
>>>> Â Â Â (avr_encode_section_info): ...to this new function.
>>>> Â Â Â (TARGET_ENCODE_SECTION_INFO): New define.
>>>> Â Â Â (avr_section_type_flags): For data in ".progmem.data", remove
>>>> Â Â Â section flag SECTION_WRITE.
>>> avr_encode_section_info is good place to emit the warning:
>>> DECL_INITIAL has stabilized for C++, the warning will appear even for
>>> unused variables that will eventually be thrown away, and the warning
>>> appears only once (new_decl_p).
>>
>> Approved.
>>
>> Denis.
>
> Is this a patch that should be backported?
> 4.6?
> 4.5?
>
> It's not fix for "bug or doc" but very annoying, false warning.

You can backport it if you want.

I'm usually didn't backport such patches.

Denis.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]