This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [annotalysis] Support IPA-SRA cloned functions (issue 4591066)
- From: Diego Novillo <dnovillo at google dot com>
- To: Delesley Hutchins <delesley at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Le-Chun Wu <lcwu at google dot com>, Ollie Wild <aaw at google dot com>
- Date: Tue, 28 Jun 2011 08:16:18 -0400
- Subject: Re: [PATCH] [annotalysis] Support IPA-SRA cloned functions (issue 4591066)
- References: <BANLkTi=+MUD=PYV_Lnq0qqKTOcWzhjPnu-yuJBnkHDwHsMwBYQ@mail.gmail.com>
On Wed, Jun 22, 2011 at 16:10, Delesley Hutchins <delesley@google.com> wrote:
>
> Hi,
> This patch is merely a port of an earlier patch, made by Le-Chun Wu,Âfrom
> google/main to annotalysis. ÂIt extendsÂAnnotalysis to support cloned
> functions/methods (especially createdÂby IPA-SRA).
> Bootstrapped and passed GCC regression testsuite on
> x86_64-unknown-linux-gnu.
> Okay for branches/annotalysis?
> Â -DeLesley
>
> 2011-06-22 ÂLe-Chun Wu Â<lcwu@google.com>, ÂDeLesley Hutchins
> <delesley@google.com>
Minor nit. Align names vertically:
2011-06-22 ÂLe-Chun Wu Â<lcwu@google.com>
DeLesley Hutchins <delesley@google.com>
> Â Â Â Â * tree-threadsafe-analyze.c (build_fully_qualified_lock): Handle
> Â Â Â Â IPA-SRA cloned methods.
> Â Â Â Â (get_canonical_lock_expr): Fold expressions that are INDIRECT_REF on
> Â Â Â Â top of ADDR_EXPR.
> Â Â Â Â (check_lock_required): Handle IPA-SRA cloned methods.
> Â Â Â Â (check_func_lock_excluded): Likewise.
> Â Â Â Â (process_function_attrs): Likewise.
OK.
Incidentally, I think it would make sense to have you added to the
list of maintainers for the annotalysis branch. Le-Chun, what do you
think?
Diego.