This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Unreviewed build/libgcc, mudflap patches


Hi -

> >>         http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01446.html
> > Looks good to me, thanks for taking a look at the area.
> 
> Could you also comment on the open questions in the submission so
> mudflap support on Solaris can be improved further?

Sure.  Transcribing:

> One generic issue came up with the port: enabling or disabling
> libmudflap depends on a factor (linker support for --wrap/-z wrap)
> that is best checked dynamically, thus doesn't really seem to belong
> at the toplevel.  Is there any precedent for performing such a test
> in the target library and enabling or disabling depending on the
> outcome?  [...]

I don't know.

> It seems the failures fall into only a few categories.  It's
> probably best to analyse and fix those before checking in the patch.
> Where should we continue discussing the failures?  Here or rather in
> the PR?

Separate PRs would be best.

- FChE


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]