This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Rename attribs.c to attributes.c
On Wed, 22 Jun 2011, Andrew MacLeod wrote:
> > Hmm, attribs.c to me is a perfect abbreviation to attributes.c, so it isn't
> > unclear (to me) ... there are more confusing file names, like tree-dfa.c
> > or tree-flow*.[ch].
> >
> I also can't imagine what else attrib.c would be other than attributes...
The *real* issue of ambiguity is that the term "attribute" means more than
one thing in GCC - in this case it relates to __attribute__, but there are
insn attributes as well.
There have been suggestions of putting GCC source files in many more
subdirectories to reflect the logical modules, and if that were done then
maybe renaming at the same time, so the file becomes tree/attributes.c or
generic/attributes.c, would make sense - and the choice of directory would
make clearer what sort of attributes are being referred to. But creating
such subdirectories requires a clear overall understanding of what the
logical divisions of source files are - a design rather than just moving
one file on its own. (I've previously discussed what should go in common/
and common/config/, driver/ and driver/config/, and it's well-established
that files built only for the target and associated build support should
go in the toplevel libgcc/ directory.)
I don't think achieving a rearrangement of the host-side and build-side
files in gcc/ would be particular hard - the changes would be mostly
mechanical - but it does require careful thought about what we want the
modules and their dependencies to be, and there would be plenty of
followup changes later to try to reduce the undesired dependencies between
the modules.
--
Joseph S. Myers
joseph@codesourcery.com