This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: gcc-patches at gcc dot gnu dot org, Richard Guenther <rguenther at suse dot de>
- Date: Thu, 09 Jun 2011 09:14:45 +0200
- Subject: Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)
- References: <ydd62qtaxg1.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <9F3CD3EC-B7DD-4DA8-BA2C-64CF6F018159@comcast.net>
Mike Stump <mikestump@comcast.net> writes:
> On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote:
>> * lto.c (promote_var): Only set VISIBILITY_HIDDEN if
>> HAVE_GAS_HIDDEN.
>
> This looks wrong, there are more things that have visibility than those things that use GAS and have .hidden. Darwin I think is one of them. ? cygming.h seems to be another.
Now that Darwin has been switched to define HAVE_GAS_HIDDEN, is the
lto.c part ok?
I've re-bootstrapped both patches together on i386-apple-darwin9.8.0,
powerpc-apple-darwin9.8.0, i386-pc-solaris2.8 and i386-pc-solaris2.11
without regressions; as expected the failure on Solaris 8/x86 is gone.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University