This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [build] Move MD_UNWIND_SUPPORT to toplevel libgcc

From: Paolo Bonzini <bonzini at gnu dot org>
To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
Cc: gcc-patches at gcc dot gnu dot org, "Joseph S. Myers" <joseph at codesourcery dot com>, Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, Douglas Rupp <rupp at gnat dot com>, Tristan Gingold <gingold at adacore dot com>, John David Anglin <dave dot anglin at nrc-cnrc dot gc dot ca>, Steve Ellcey <sje at cup dot hp dot com>, Kai Tietz <ktietz at redhat dot com>, Dave Korn <dave dot korn dot cygwin at gmail dot com>, Mike Stump <mikestump at comcast dot net>
Date: Tue, 31 May 2011 11:02:47 +0200
Subject: Re: [build] Move MD_UNWIND_SUPPORT to toplevel libgcc
References: <yddr57gry79.fsf@manam.CeBiTec.Uni-Bielefeld.DE>

On 05/30/2011 05:43 PM, Rainer Orth wrote:

+md-unwind-support.h: config.status
+	if test -n "$(md_unwind_header)"; then \
+	  echo "#include \"config/$(md_unwind_header)\"">  $@; \
+	else \
+	  :>  $@; \
+	fi

Can you add a default file md-unwind-none.h and use

AC_CONFIG_LINKS([md-unwind-support.h:$md_unwind_header])

instead of this (and instead of AC_SUBST'ing the variable)?

-libgcc-eh-objects += $(addsuffix $(objext),$(basename $(notdir $(LIB2ADDEHSTATIC))))
-libgcc-s-objects += $(addsuffix _s$(objext),$(basename $(notdir $(LIB2ADDEHSHARED))))
+libgcc-eh-static-objects := $(addsuffix $(objext),$(basename $(notdir $(LIB2ADDEHSTATIC))))
+libgcc-eh-shared-objects := $(addsuffix _s$(objext),$(basename $(notdir $(LIB2ADDEHSHARED))))
+
+$(libgcc-eh-static-objects) $(libgcc-eh-shared-objects): md-unwind-support.h
+
+libgcc-eh-objects += $(libgcc-eh-static-objects)
+libgcc-s-objects += $(libgcc-eh-shared-objects)

These changes to the dependencies should not be necessary, libgcc does automatic dependency tracking.

Also a good start, though. Thanks for this work.

Paolo

Follow-Ups:
- Re: [build] Move MD_UNWIND_SUPPORT to toplevel libgcc
  - From: Rainer Orth

References:
- [build] Move MD_UNWIND_SUPPORT to toplevel libgcc
  - From: Rainer Orth

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]