This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [testsuite] remove XFAIL for all but ia64 for g++.dg/tree-ssa/pr43411.C


On Thu, May 26, 2011 at 5:16 PM, Mike Stump <mikestump@comcast.net> wrote:
> On May 26, 2011, at 2:25 AM, Richard Guenther wrote:
>> The XPASS is suprious - that's the whole point of XPASSes. ?It should
>> FAIL (well, XFAIL). ?A patch making it PASS is bogus.
>
> There are deeper reasons for my position. ?Take a look at:
>
> ?http://google1.osuosl.org:8011/waterfall
>
> the idea is to use the expected state of the testcases to determine if the color should be green or not. ?The best use of a system like this is when the usual state is green, and any time a red appears, it is turned back to green, in time measures in minutes or hours, not days or years. ?Now, do you think there is any value add to having a testing system that displays testing results across many platforms on a regular basis like this? ?If so, how do you propose to decide on wether the color should be green or red?

It's always red on a transition.  Whether an XPASS or XFAIL is red on
its own needs human interaction (understanding of the testcase and
why it now XPASSes or XFAILs).  The red on the transition should
cause the human that did that transition to do that inspection.

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]