This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR target/48807
- From: Bernd Schmidt <bernds at codesourcery dot com>
- To: "Henderson, Stuart" <Stuart dot Henderson at analog dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 26 May 2011 13:23:54 +0000
- Subject: Re: [PATCH] Fix PR target/48807
- References: <05E9E85E39C35B4D96ED3A3190E35A10A49CDA1888@LIMKCMBX1.ad.analog.com>
On 05/19/2011 12:39 PM, Henderson, Stuart wrote:
> * config/bfin/bfin.c: Check return value of cgraph_local_info for null before
> attempting to use it.
Needs to mention the function name, and wrap the long line properly.
> Index: gcc/config/bfin/bfin.c
> ===================================================================
> --- gcc/config/bfin/bfin.c (revision 173363)
> +++ gcc/config/bfin/bfin.c (working copy)
> @@ -2077,6 +2077,8 @@
Using the "-p" option for diff is preferrable. See
http://gcc.gnu.org/wiki/SvnTricks
> this_func = cgraph_local_info (current_function_decl);
> called_func = cgraph_local_info (decl);
> + if (!called_func || !this_func)
> + return false;
> return !called_func->local || this_func->local;
> }
Ok, although I think this_func should never be NULL?
Bernd