This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR45098, 3/10]
Hi Zdenek,
On 05/18/2011 05:24 PM, Zdenek Dvorak wrote:
> Hi,
>
>> How about:
>> ...
>> @@ -2866,6 +2878,8 @@ computation_cost (tree expr, bool speed)
>> if (MEM_P (rslt))
>> cost += address_cost (XEXP (rslt, 0), TYPE_MODE (type),
>> TYPE_ADDR_SPACE (type), speed);
>> + else if (!REG_P (rslt))
>> + cost += (unsigned)rtx_cost (rslt, SET, speed);
>>
>> return cost;
>> }
>> ...
>> ?
>
> this looks ok to me
>
thanks for the review.
> (the cast to unsigned is not necessary, though?)
You're right, it's not, that was only necessary to prevent a warning in the
conditional expression originally proposed.
Checked in without cast.
Thanks,
- Tom