This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch ada]: Fix boolean_type_node setup and some cleanup for boolean use
2011/5/17 Eric Botcazou <ebotcazou@adacore.com>:
>> 2011-05-16 ?Kai Tietz
>>
>> ? ? ? PR middle-end/48989
>> ? ? ? * gcc-interface/trans.c (Exception_Handler_to_gnu_sjlj): Use
>> ? ? ? boolean_false_node instead of integer_zero_node.
>> ? ? ? (convert_with_check): Likewise.
>> ? ? ? * gcc-interface/decl.c (choices_to_gnu): Likewise.
>
> OK for this part.
>
>> ? ? ? * gcc-interface/misc.c (gnat_init): Set precision for
>> ? ? ? generated boolean_type_node and initialize
>> ? ? ? boolean_false_node.
>
> Not OK, you cannot set the precision of boolean_type_node to 1 in Ada.
>
> --
> Eric Botcazou
Hmm, sad. As the a check in tree-cfg for truth-expressions about
having type-precision of 1 would be a good way. What is actual the
cause for not setting type-precision here? At least in testcases I
didn't found a regression caused by this.
Regards,
Kai