This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] fixincludes: fix solaris_complex_cxx rule syntax
On May 16, 2011, at 3:40 PM, Bruce Korb wrote:
> Hi Tristan,
>
> On Mon, May 16, 2011 at 6:20 AM, Tristan Gingold <gingold@adacore.com> wrote:
>> Hi,
>>
>> this rule (and only this one) uses the c function of sed. According to man, the syntax should be:
>>
>> [2addr]c\
>> text
>>
>> (Note the trailing back-slash).
>> But as currently written, there is no backslash in it. As a consequence 'make check' fails at least on Darwin (BSD derived sed
>> command). I think it would be better to stick with the common syntax, as done by this patch.
>>
>> Tested with 'make check'.
>
> Tested with 'make check' on which platforms?
> I am sure it includes Darwin (iOS/OSX/Apple), but assurance is needed about
> other flavors of "sed" e.g.,
> GNU
> Solaris
> HP/UX
> AIX
Yes, it is ok on GNU/Linux and Solaris.
Do I really need to test on HP/UX and AIX ? Won't be easy for me.
Tristan.
>> Ok for trunk ?
>
> Probably. :) Just assure us it is properly tested.