This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [build] Define HAVE_GAS_HIDDEN on Darwin
- From: Mike Stump <mikestump at comcast dot net>
- To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- Cc: gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Iain Sandoe <iains at gcc dot gnu dot org>
- Date: Mon, 9 May 2011 17:43:27 -0700
- Subject: Re: [build] Define HAVE_GAS_HIDDEN on Darwin
- References: <yddiptqbrdb.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
On May 4, 2011, at 5:08 AM, Rainer Orth wrote:
> The following patch is a prerequisite for making
>
> [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)
> http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00295.html
> -# define USE_LINKONCE_INDIRECT (SUPPORTS_ONE_ONLY)
> +# define USE_LINKONCE_INDIRECT (SUPPORTS_ONE_ONLY) && !TARGET_MACHO
Generally speaking, we don't litter the backend with things like this. We consider this trashy, and we limit the trash to config/...
Now, if you invent a feature (bug) for which this is really testing, and used it instead here, and then put that into the darwin.h file or into an as autoconf test, I think it would be fine. Ok with that version. If a build/configure/visibility person wants to object or insist on a better way to do what you want to do, I'd defer to them.