This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING] Fix PR46399 - missing mode promotion for libcall args
- From: Ian Lance Taylor <iant at google dot com>
- To: "Andreas Krebbel" <krebbel at linux dot vnet dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, rguenther at suse dot de
- Date: Wed, 13 Apr 2011 06:31:01 -0700
- Subject: Re: [PING] Fix PR46399 - missing mode promotion for libcall args
- References: <20110413105432.GA5425@bart>
"Andreas Krebbel" <krebbel@linux.vnet.ibm.com> writes:
> This fixes a wrong code generation bug for sw DFP:
>
> http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00141.html
Why do we need a new target hook just for libcalls? Why not just use
the existing TARGET_PROMOTE_FUNCTION_MODE hook? We could say that for a
libcall functype is passed as NULL. Only the SH cares about the
function type at all, and it is already prepared to handle NULL.
Ian