This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses
- From: Ian Lance Taylor <iant at google dot com>
- To: Nathan Froyd <froydnj at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, dnovillo at google dot com
- Date: Tue, 12 Apr 2011 21:02:28 -0700
- Subject: Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses
- References: <1299817406-16745-1-git-send-email-froydnj@codesourcery.com> <1299817406-16745-3-git-send-email-froydnj@codesourcery.com> <20110413024341.GT23480@codesourcery.com>
Nathan Froyd <froydnj@codesourcery.com> writes:
> On Thu, Mar 10, 2011 at 11:23:10PM -0500, Nathan Froyd wrote:
>> Now that we have a structure where not every node might include
>> TREE_CHAIN or TREE_TYPE, we need to make sure that when we call said
>> accessors that the argument is properly typed. This requires a number
>> of changes:
>
> http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00565.html
>
> Ping. I was going to commit this, but I realized I hadn't received
> approval for the go or LTO bits. They probably qualify as obvious,
> given that they're exactly the same as all the other languages, but just
> to rubber-stamp everything...
>
>> gcc/go/
>> * go-lang.c (union lang_tree_node): Check for TS_COMMON before
>> calling TREE_CHAIN.
>>
>> gcc/lto/
>> * lto-tree.h (union lang_tree_node): Check for TS_COMMON before
>> calling TREE_CHAIN.
>> * lto.c (lto_fixup_common): Likewise.
This is OK.
Thanks.
Ian