This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [pph/libcpp] Allow include callback to not read the file (issue4388057)

From: Diego Novillo <dnovillo at google dot com>
To: Lawrence Crowl <crowl at google dot com>
Cc: reply at codereview dot appspotmail dot com, tromey at redhat dot com, gcc-patches at gcc dot gnu dot org
Date: Tue, 12 Apr 2011 20:50:34 -0400
Subject: Re: [pph/libcpp] Allow include callback to not read the file (issue4388057)
References: <20110412202845.164371DA1BE@topo.tor.corp.google.com> <BANLkTi=QU-ie8D=6kegfXmO2hMn2KpUTTQ@mail.gmail.com>

On Tue, Apr 12, 2011 at 20:41, Lawrence Crowl <crowl@google.com> wrote:
> This change is not source compatible with existing code using
> the callbacks (which may not be in the gcc svn). ÂPerhaps a new
> callback is needed?

Well, it only changes the return value for the callback.  Existing
users do not really need to be changed.

I don't think we want a new callback.  The callback would do exactly
what cb.include does.

Diego.

Follow-Ups:
- Re: [pph/libcpp] Allow include callback to not read the file (issue4388057)
  - From: Tom Tromey

References:
- [pph/libcpp] Allow include callback to not read the file (issue4388057)
  - From: Diego Novillo
- Re: [pph/libcpp] Allow include callback to not read the file (issue4388057)
  - From: Lawrence Crowl

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]