This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, fortran] More control over front end optimization
- From: Daniel Kraft <d at domob dot eu>
- To: Thomas Koenig <tkoenig at netcologne dot de>
- Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 07 Apr 2011 21:50:46 +0200
- Subject: Re: [patch, fortran] More control over front end optimization
- References: <4D9E1168.50908@netcologne.de>
Hi,
On 04/07/11 21:32, Thomas Koenig wrote:
following Joost's request, the attached patch gives the user more
control over front end optimization - it can now be selected or
deselected independent of normal optimization. I have also implemented a
warning for eliminated functions.
Regression-tested.
Once this is in, I will also mention the new options in the changes file.
OK for trunk?
Ok. Just my opinion (as non-native-speaker), though:
+Wfunction-elimination
+Fortran Warning
+Warn about function call elimination
"-Wfunction-elimination" sounds misleading to me -- just under the name,
I would imagine you mean eliminating whole functions; as in "never used
(anymore), remove". Since you mean elimination of *calls* to functions,
could you use something like "-Wcall-elimination"? (Does not sound that
much better... but if you have an idea, I would prefer a clearer option
name. Otherwise just leave it.)
+Warn if any calls to functions are eliminated by the
+@option{-ffrontend-optimize} option.
I also do not completely like "are eliminated by the -ffrontend-optimize
option" -- since to me it is not *the option* which eliminates the
calls; but the elimination is implied by the option... or something like
that. But as before, if you have a good alternative I would love to see
one, otherwise just leave it.
The code looks good to me.
Yours,
Daniel
--
http://www.pro-vegan.info/
--
Done: Arc-Bar-Cav-Kni-Ran-Rog-Sam-Tou-Val-Wiz
To go: Hea-Mon-Pri