This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [google] Build libstdc++ exception throwing code with frame pointers (issue4348050)
- From: Diego Novillo <dnovillo at google dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: reply at codereview dot appspotmail dot com, gcc-patches at gcc dot gnu dot org
- Date: Tue, 5 Apr 2011 09:06:19 +0200
- Subject: Re: [google] Build libstdc++ exception throwing code with frame pointers (issue4348050)
- References: <20110404210505.0E2A91909EB@elbrus2.mtv.corp.google.com>
On Mon, Apr 4, 2011 at 23:05, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
> 2011-04-04 ÂPaul Pluzhnikov Â<ppluzhnikov@google.com>
>
> Â Â Â Â* libstdc++-v3/src/Makefile.am Â(revision 171950): Add
> Â Â Â Â-fno-omit-frame-pointer to functexcept.
>    Â* libstdc++-v3/libsupc++/Makefile.am  Â(revision 171950): Add
> Â Â Â Â-fno-omit-frame-pointer to eh_throw and eh_terminate.
> Â Â Â Â* libstdc++-v3/src/Makefile.in Â(revision 171950): Regenerate.
>    Â* libstdc++-v3/libsupc++/Makefile.in  Â(revision 171950): Regenerate.
Remove the '(revision 171950)' strings.
>
> Index: libstdc++-v3/src/Makefile.am
> ===================================================================
> --- libstdc++-v3/src/Makefile.am    Â(revision 171950)
> +++ libstdc++-v3/src/Makefile.am    Â(working copy)
> @@ -395,7 +395,8 @@
> Â Â Â Â$(XTEMPLATE_FLAGS) \
> Â Â Â Â$(WARN_CXXFLAGS) \
> Â Â Â Â$(OPTIMIZE_CXXFLAGS) \
> - Â Â Â $(CONFIG_CXXFLAGS)
> + Â Â Â $(CONFIG_CXXFLAGS) \
> + Â Â Â $($(@)_no_omit_frame_pointer)
>
>
> Â# libstdc++ libtool notes
> @@ -469,3 +470,6 @@
> Âinstall_debug:
> Â Â Â Â(cd ${debugdir} && $(MAKE) \
> Â Â Â Âtoolexeclibdir=$(glibcxx_toolexeclibdir)/debug install)
> +
> +# Google-specific pessimization
> +functexcept.lo_no_omit_frame_pointer = -fno-omit-frame-pointer
Does this mean that this is not intended to go to trunk ever? If so,
it may make more sense to put this in google/integration instead of
google/main.
Diego.