This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 15/18] move REAL_IDENTIFIER_TYPE_VALUE to be a field of lang_identifier

From: Jason Merrill <jason at redhat dot com>
To: Nathan Froyd <froydnj at codesourcery dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Fri, 11 Mar 2011 08:40:24 -0500
Subject: Re: [PATCH 15/18] move REAL_IDENTIFIER_TYPE_VALUE to be a field of lang_identifier
References: <1299817406-16745-1-git-send-email-froydnj@codesourcery.com> <1299817406-16745-16-git-send-email-froydnj@codesourcery.com>

On 03/10/2011 11:23 PM, Nathan Froyd wrote:

I'm not overly fond of the conditionals (especially in error_operand_p)
but I don't think it's reasonable to make IDENTIFIER_NODE bigger and
penalize the other FEs just because the C++ FE is playing games with
TREE_TYPE.

The C++ FE expects that we can check the TREE_TYPE of anything that appears as an expression, and uses IDENTIFIER_NODE to indicate a dependent name within templates. If you want to break TREE_TYPE on IDENTIFIER_NODE, you need to change the representation of dependent names so that we can continue to use TREE_TYPE on all expressions.

Jason

Follow-Ups:
- Re: [PATCH 15/18] move REAL_IDENTIFIER_TYPE_VALUE to be a field of lang_identifier
  - From: Nathan Froyd
- Re: [PATCH 15/18] move REAL_IDENTIFIER_TYPE_VALUE to be a field of lang_identifier
  - From: Joseph S. Myers

References:
- [4.7 PATCH 00/18] slim down a number of tree nodes
  - From: Nathan Froyd
- [PATCH 15/18] move REAL_IDENTIFIER_TYPE_VALUE to be a field of lang_identifier
  - From: Nathan Froyd

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]