This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [pph] Add error for pre-parsing unguarded headers.

From: Diego Novillo <dnovillo at google dot com>
To: Lawrence Crowl <crowl at google dot com>
Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
Date: Thu, 24 Feb 2011 18:37:08 -0500
Subject: Re: [pph] Add error for pre-parsing unguarded headers.
References: <AANLkTi=imRuCZHEB4fRV75vEbaUteTBdmBWcp_7jV0L1@mail.gmail.com> <4D66DF38.4040209@google.com> <AANLkTikUVLrw506gxWh2q3fXHa6akjaQKFxifTTy8qto@mail.gmail.com>

On Thu, Feb 24, 2011 at 18:27, Lawrence Crowl <crowl@google.com> wrote:

> You are in a maze of twisty coding conventions, none alike.

:)

> Technically, yes. ÂIt was unclear to me whether that was something
> we wanted to support. ÂThe current code is conservative, in that
> support can be added without incompatibilities.

Sounds good.

> The test for file->main_file ensures that we return at most the
> main file. Â(Unless somehow we get two main files.)

Ah, yeah, I missed that.

Patch is OK.  Thanks.


Diego.

References:
- [pph] Add error for pre-parsing unguarded headers.
  - From: Lawrence Crowl
- Re: [pph] Add error for pre-parsing unguarded headers.
  - From: Diego Novillo
- Re: [pph] Add error for pre-parsing unguarded headers.
  - From: Lawrence Crowl

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]